Skip to content

update androidx.sqlite/sqlite -> 2.1.0 #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

update androidx.sqlite/sqlite -> 2.1.0 #501

merged 1 commit into from
Jan 10, 2023

Conversation

brody4hire
Copy link

@brody4hire brody4hire commented Mar 24, 2020 •
edited
Loading

UPDATED January 2023:

I think it would be ideal to update this androidx.sqlite/sqlite to 2.2.0, but it looks to me like this would incur a requirement for Android SDK 31. I am not sure if we are ready for this kind of breaking change yet.

This is just a suggestion to use the latest version of androidx.sqlite from https://mvnrepository.com/artifact/androidx.sqlite/sqlite. This worked for me when using my custom build in an Apache Cordova test project. I hope I will have a chance to test an AAR with the test suite in sqlcipher-android-tests in the near future, no promises due to some urgent project work. I am raising this as a draft PR for now.

@commonsguy
Copy link
Collaborator

I think we need to make some modifications for this to work. If nothing else, they added useNoBackupDirectory to SupportSQLiteOpenHelper.Configuration. We probably need to honor that.

@brody4hire brody4hire changed the title androidx.sqlite:sqlite:2.1.0 update [WIP] androidx.sqlite:sqlite:2.1.0 update Mar 24, 2020
@piotr-pawlowski
Copy link

Please consider update androidx.sqllite to 2.1.0.

Here is an example of implementation for useNoBackupDirectory:
https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.java#61

@developernotes
Copy link
Member

Hello @piotr-pawlowski

We are just finishing efforts on the next public SQLCipher release. Unfortunately, an update to the androidx.sqlite dependency will need to occur in a follow-up release. We have added it to our backlog. Thanks!

@brody4hire brody4hire closed this Jan 12, 2021
@brody4hire brody4hire deleted the patch-1 branch January 12, 2021 17:20
@epicstar
Copy link

epicstar commented May 25, 2021 •
edited
Loading

Hello. I noticed that this was closed. Is androidx.sqlite updated to 2.1.0?

@brody4hire brody4hire restored the patch-1 branch May 25, 2021 17:22
@brody4hire brody4hire reopened this May 25, 2021
@brody4hire brody4hire changed the title [WIP] androidx.sqlite:sqlite:2.1.0 update androidx.sqlite/sqlite 2.1.0 update May 25, 2021
@brody4hire brody4hire marked this pull request as ready for review May 25, 2021 17:26
@brody4hire
Copy link
Author

Nope, just reopened.

brody4hire
brody4hire commented Jan 4, 2023
View reviewed changes
@brody4hire brody4hire changed the title androidx.sqlite/sqlite 2.1.0 update DRAFT RFC: androidx.sqlite/sqlite 2.x.x update Jan 4, 2023
@brody4hire brody4hire marked this pull request as draft January 4, 2023 18:59
@brody4hire brody4hire changed the title DRAFT RFC: androidx.sqlite/sqlite 2.x.x update androidx.sqlite/sqlite 2.2.0 update Jan 8, 2023
@brody4hire brody4hire marked this pull request as ready for review January 8, 2023 18:49
@brody4hire brody4hire marked this pull request as draft January 8, 2023 19:36
brody4hire
brody4hire commented Jan 8, 2023
View reviewed changes
@brody4hire brody4hire changed the title androidx.sqlite/sqlite 2.2.0 update update androidx.sqlite/sqlite -> 2.1.0 Jan 8, 2023
@brody4hire brody4hire marked this pull request as ready for review January 8, 2023 19:47
@brody4hire
Copy link
Author

I hope we can consider getting this one updated to 2.1.0 or 2.2.0. I think 2.2.0 would be ideal but it seems to require Android SDK 31 update.

@brody4hire brody4hire mentioned this pull request Jan 10, 2023
Open
@developernotes developernotes merged commit 79dc739 into sqlcipher:master Jan 10, 2023
@developernotes
Copy link
Member

Hi @brodybits,

This is merged into master, thanks!

@brody4hire brody4hire deleted the patch-1 branch January 10, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brody4hire @commonsguy @piotr-pawlowski @developernotes @epicstar